fix(mcp): preserve transport event deadline values and provenance - #437

Review follow-up — a3f4c0e

Addressed Maurycy's review: active-only milestones/categories and compact summaries; withdrawn history retained in the full timeline; concrete latest-event/formatter types; opaque reported JSON preserved only at the two event-value paths; final-response tests on both tools; shorter tool description with detailed guidance in the query resource. All five review threads answered and resolved. Remote checks pending; no merge or live customer verification.

Summary

Fixes DEV-13524: preserve public transport-event value, data_source, and invalidated_at instead of discarding them during MCP formatting.

• Applies to the dedicated timeline endpoint and its container-include fallback, plus the compact snapshot's latest-event summary.
• Uses the same tool description for registered discovery and the standalone definition, documenting reported deadline values versus event timestamps; the longer playbook lives in the query-guidance resource.
• Keeps values as supplied (including structured JSON, false, zero, and empty strings); absent values become null. Does not infer or calculate deadlines.

For container.detention_lfd_line.changed, the deadline is the API's value, not timestamp. Pickup LFD remains separate and unchanged. This fixes information loss where an event is reported; it does not establish carrier coverage or promise an empty-return deadline for every container. No t49/backend changes, agent prompt changes, auth changes, or SQL-tool dependencies.

Verification

• 430 MCP tests pass, including the original 17 executor regressions and 10 registered-response regressions. The full workspace suite also passes: 359 SDK + 31 CLI tests, with one existing SDK skip.
• Repository npm run check passes (existing lint warnings remain).
• SDK and MCP builds pass.
• All six supported MCP protocol smoke versions pass.
• git diff --check passes.
• Synthetic fixtures only; no live customer calls or deployment verification.

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Confidence Score: 4/5

The PR appears safe to merge, with non-blocking fixes recommended for structured values and the snapshot return type.

Findings

1.  Reported fields can disappear ▶
2.  New fields lack types ▶

### Issue 1
packages/mcp/src/tools/get-container-transport-events.ts:220
Structured `value` objects can still lose fields in actual MCP responses. `wrapTool` passes the whole result through `stripResponseSteering`, which recursively removes `_agent_steering` and `_response_contract`, plus fields such as `recommendations` beneath any `_metadata` key. For example, `{"_metadata":{"recommendations":["reported"]}}` becomes `{"_metadata":{}}`. This affects both the timeline and compact snapshot.

Keep reported event values outside this cleanup and add a test through the registered tool; the new executor tests stop before this step. Greptile automatically discovered a related ticket stating that structured event values must be preserved, which informed this comment.

### Issue 2
packages/mcp/src/tools/get-container.ts:388-390
`formatEventsData` now returns `value`, `data_source`, and `invalidated_at`, but `ContainerStatus.events.latest_event` still declares only `event`, `timestamp`, and `location`. Since `executeGetContainer` returns `Promise<ContainerStatus>`, TypeScript callers cannot access the new fields without a cast.

Add these fields to the declared return type, using `unknown` for arbitrary reported `value`.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

_{Reviews (1) · Last reviewed commit: "fix(mcp): preserve transport event value..." · Reviewed by Greptile}